From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 08 Jan 2019 21:35:54 GMT
Subject: Re: sb/more-repo-in-api, was Re: What's cooking in git.git (Jan 2019, #01; Mon, 7)
Message-ID: <xmqqr2dm4yth.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190108212007.10855-1-jonathantanmy@google.com>

Jonathan Tan <jonathantanmy@google.com> writes:

>>  The in-core repository instances are passed through more codepaths.
>
> I think this is ready to be considered for merging to next. This series looks
> good both to Stolee [1] and to me (I replied to a previous version with
> comments on patch 18 [2] which Stefan has addressed, as can be seen in the
> inter-diff provided by Junio [3] - I probably should have replied to the latest
> version stating this too).

Alright, thanks.

While attempting to resolve conflicts with this and Peff's "get rid
of has_sha1_file()" topic, I found it somewhat disturbing that
sha1-file.c still was a mixture of functions that do and do not take
the repository pointer, but perhaps it's something we need to polish
over time on top.