From: Junio C Hamano Date: Fri, 22 Feb 2019 23:23:24 GMT Subject: Re: [PATCH v2 6/6] Makefile: allow for combining DEVELOPER=1 and CFLAGS="..." Message-ID: In-Reply-To: <20190222144127.32248-7-avarab@gmail.com> Ævar Arnfjörð Bjarmason writes: > diff --git a/config.mak.dev b/config.mak.dev > index 7354fe15b3..bf1f3fcdee 100644 > --- a/config.mak.dev > +++ b/config.mak.dev > @@ -1,41 +1,41 @@ > ifeq ($(filter no-error,$(DEVOPTS)),) > -CFLAGS += -Werror > +DEVELOPER_CFLAGS += -Werror This is the first mention of DEVELOPER_CFLAGS; what is -Werror appended to? Any random thing in the environment or command line? > endif