From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 22 Feb 2021 23:39:07 GMT
Subject: Re: [PATCH v2] rebase: add a config option for --no-fork-point
Message-ID: <xmqqr1l765b8.fsf@gitster.g>
In-Reply-To: <20210220051025.4672-1-alexhenrie24@gmail.com>

Alex Henrie <alexhenrie24@gmail.com> writes:

> +test_expect_success 'rebase.forkPoint set to false' '
> +	test_config rebase.forkPoint false &&
> +	test_rebase "G F C E D B A"
> +'
> +
> +test_expect_success 'rebase.forkPoint set to false and then to true' '
> +	test_config_global rebase.forkPoint false &&
> +	test_config rebase.forkPoint true &&
> +	test_rebase "G F E D B A"
> +'
> +
> +test_expect_success 'rebase.forkPoint set to false and command line says --fork-point' '
> +	test_config rebase.forkPoint false &&
> +	test_rebase "G F E D B A" --fork-point
> +'
> +
> +test_expect_success 'rebase.forkPoint set to true and command line says --no-fork-point' '
> +	test_config rebase.forkPoint true &&
> +	test_rebase "G F C E D B A" --no-fork-point
> +'

All of these four look dubious, as test_rebase is defined to run its
own test_expect_success in it.