From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 12 May 2023 19:31:52 GMT
Subject: Re: [PATCH v5 7/7] strbuf: remove global variable
Message-ID: <xmqqr0rlpcrb.fsf@gitster.g>
In-Reply-To: <c9e22e51-4e4a-b692-edfd-1f3bc7ee7da9@gmail.com>

Phillip Wood <phillip.wood123@gmail.com> writes:

> Hi Calvin
>
> On 11/05/2023 20:48, Calvin Wan wrote:
>> As a library that only interacts with other primitives, strbuf should
>> not utilize the comment_line_char global variable within its
>> functions. Therefore, add an additional parameter for functions that use
>> comment_line_char and refactor callers to pass it in instead.
>> strbuf_stripspace() removes the skip_comments boolean and checks if
>> comment_line_char is a non-NULL character to determine whether to skip
>> comments or not.
>
> Thanks for re-rolling, I agree with Eric's comments but would be happy
> if this was merged as-is.

Thanks for reviewing.