From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 19 Aug 2024 21:21:44 GMT
Subject: Re: [PATCH v5 2/9] t: import the clar unit testing framework
Message-ID: <xmqqr0akcion.fsf@gitster.g>
In-Reply-To: <369060793306daab1796ae3063b4eaacc287f12d.1723791831.git.ps@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

> diff --git a/t/unit-tests/clar/clar.c b/t/unit-tests/clar/clar.c
> new file mode 100644
> index 0000000000..3fc2c76815
> --- /dev/null
> +++ b/t/unit-tests/clar/clar.c
> @@ -0,0 +1,842 @@
> ...
> +
> +#ifdef _WIN32
> +#	include <windows.h>
> +#	include <io.h>
> +#	include <shellapi.h>
> +#	include <direct.h>

This seems to break Windows build

  In file included from t/unit-tests/clar/clar.c:22:
  D:/git-sdk-64-minimal/mingw64/include/windows.h:89:10: fatal error: shellapi.h: No such file or directory
     89 | #include <shellapi.h>
        |          ^~~~~~~~~~~~
  compilation terminated.

https://github.com/git/git/actions/runs/10459342252/job/28963152995

As we have other topics that I do want to do well in 'seen' before
merging them to 'next', I'd temporarily drop this topic from 'seen'
and push out the rest of the topics.