From: Junio C Hamano Date: Fri, 27 Dec 2024 16:02:07 GMT Subject: Re: [PATCH 0/4] reftable: fix realloc error handling Message-ID: In-Reply-To: Patrick Steinhardt writes: > On Wed, Dec 25, 2024 at 07:33:07PM +0100, René Scharfe wrote: >> The current handling of reallocation errors leaks the original >> allocation in most cases and corrupts the capacity variable. Fix >> that in REFTABLE_ALLOC_GROW and by providing a new macro >> REFTABLE_ALLOC_GROW_OR_NULL -- solve this somewhat tricky issue >> centrally, with minimal impact to calling code. >> >> And the last two patches add error handling to the remaining >> places that still lack it. > > Thanks a lot for working on this! And thank you for reviewing.