From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 24 Apr 2025 12:43:15 GMT
Subject: Re: [PATCH v4 3/3] send-email: add option to generate passswords like OAuth2 tokens
Message-ID: <xmqqr01hvifw.fsf@gitster.g>
In-Reply-To: <PN3PR01MB9597B700337C132A0FB053FFB8852@PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM>

Aditya Garg <gargaditya08@live.com> writes:

>> On 24 Apr 2025, at 12:33 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> 
>> Aditya Garg <gargaditya08@live.com> writes:
>> 
>>> @@ -230,6 +230,14 @@ or on the command line. If a username has been specified (with
>>> specified (with `--smtp-pass` or `sendemail.smtpPass`), then
>>> a password is obtained using 'git-credential'.
>>> 
>>> +--smtp-passeval[=<command>]::
>> 
>> Lose the pair of [] that marks the value optional.  Compare it with,
>> say, --smtp-user that is described as:
>
> The value is not optional. It doesn't make sense to leave this empty right?

That is why I said "Lose the pair of []".  IOW what we see above is
wrong and it should be something like

    --smtp-passeval=<command>::

without the [].  Just like --smtp-user takes a mandatory <user>,
like this:

>>    --smtp-user=<user>::
>>            Username for SMTP-AUTH. Default is ...

your "passeval" takes a mandatory <command>, hence =<command> should
NOT be enclosed in a pair of [].