From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 14 Jul 2025 16:42:33 GMT
Subject: Re: [PATCH v4 4/4] for-each-ref: introduce a '--start-after' option
Message-ID: <xmqqqzyiu3k6.fsf@gitster.g>
In-Reply-To: <CAP8UFD1wRxZDCRC76VuuA8_rpNn__TQnL9RnNumCE33wAjSrMQ@mail.gmail.com>

Christian Couder <christian.couder@gmail.com> writes:

>>         /*  Simple per-ref filtering */
>> -       if (!filter->kind)
>> +       if (!filter->kind) {
>>                 die("filter_refs: invalid type");
>> -       else {
>> +       } else {
>
> Nit: the `else` could be removed altogether here, but maybe that
> should be done in a preparatory patch.

Good eyes.  Thanks for carefully reading it over.