From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 04 Nov 2025 14:35:44 GMT
Subject: Re: [PATCH v2] doc: clarify server behavior for invalid 'want' lines in HTTP protocol
Message-ID: <xmqqqzudrhkv.fsf@gitster.g>
In-Reply-To: <20251104100653.2152-1-qjessa662@gmail.com>

Queen Ediri Jessa <qjessa662@gmail.com> writes:

> From: QueenJcloud <qjessa662@gmail.com>
>
>
> From: Queen Ediri Jessa <qjessa662@gmail.com>
>
>
> Update the documentation to clearly describe how the server responds when a
> client sends an invalid or malformed `want` line during the HTTP protocol
> exchange. This improves understanding of Git’s behavior when handling
> incorrect object requests and helps developers detect and handle such
> protocol issues accurately.
>
> Signed-off-by: Queen Ediri Jessa <qjessa662@gmail.com>
>
> Changes since v1:
> - Rephrased the explanation to be more concise and aligned with reviewer
>   feedback.
> - Clarified that the server includes the offending object name in its error
>   message.
> - Adjusted tone to describe the expected behavior rather than prescribing
>   implementation-specific messages.
> - Improved readability and technical consistency of the section.
> ---
>  Documentation/gitprotocol-http.adoc | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

I'll locally fix up before queuing this time, but

 * You now have one in-body header to force "From: QueenJcloud",
   after which the blank line declares everything below is the body
   and no in-body header remains, and then you have another line
   "From: Queen Ediri Jessa" that is not an in-body header.  Perhaps
   you should send your e-mail only to yourself without sending to
   the list as practice to prevent them from appearing again?  You
   only want the second one, IIUC.

 * Describing "Changes since..." is a very good idea, but that
   should be done _after_ the three-dash line, not beffore.

Thanks.

> diff --git a/Documentation/gitprotocol-http.adoc b/Documentation/gitprotocol-http.adoc
> index d024010414..f3f48d3f35 100644
> --- a/Documentation/gitprotocol-http.adoc
> +++ b/Documentation/gitprotocol-http.adoc
> @@ -443,7 +443,10 @@ If no "want" objects are received, send an error:
>  TODO: Define error if no "want" lines are requested.
>  
>  If any "want" object is not reachable, send an error:
> -TODO: Define error if an invalid "want" is requested.
> +When a Git server receives an invalid or malformed `want` line, it
> +responds with an error message that includes the offending object name.
> +This clarifies the expected behavior for Git implementations and helps
> +clients detect protocol issues accurately during fetch operations.
>  
>  Create an empty list, `s_common`.