From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 23 Nov 2025 02:41:06 GMT
Subject: Re: [PATCH] ci(dockerized): do show the result of failing tests again
Message-ID: <xmqqqztp1nel.fsf@gitster.g>
In-Reply-To: <xmqqpl9gike6.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

>> The solution is simple: make the file world-writable.
>
> I expected to see a+w not o+w from this statement; as long as it
> works I have no strong objections, but if I saw o+w without the
> above explanation I would probably have wondered who are in the
> group that we do not want this file touched by.
> ...
>>      - run: useradd builder --create-home
>>      - run: chown -R builder .
>> -    - run: sudo --preserve-env --set-home --user=builder ci/run-build-and-tests.sh
>> +    - run: chmod o+w $GITHUB_ENV && sudo --preserve-env --set-home --user=builder ci/run-build-and-tests.sh
>>      - name: print test failures

Unless I hear that "user X belongs to the same group as our user
that runs 'chmod' on $GITHUB_ENV, and we do not want that user to be
writing into the file", I'll amend the patch text to match the
"solution" described in the proposed log message to "chmod a+w",
before we mark the topic for 'next'.

Thanks.