From: Junio C Hamano Date: Wed, 25 Mar 2026 17:35:17 GMT Subject: Re: [PATCH v4 1/2] repo: factor repo usage strings into shared macros Message-ID: In-Reply-To: <20260325115148.101867-1-mahlet.takassa@gmail.com> Mahi Kassa writes: > Factor the "git repo info" and "git repo structure" usage > strings into shared macros so they can be reused in multiple > usage arrays. > > This is a preparatory refactoring for subsequent changes to > subcommand-specific help output. > > Signed-off-by: Mahi Kassa > > --- > v4: > - split the preparatory macro refactoring into its own patch > builtin/repo.c | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) Looking good. The distribution of commas are sensible, too. > diff --git a/builtin/repo.c b/builtin/repo.c > index 55f9b9095c..b5146499d0 100644 > --- a/builtin/repo.c > +++ b/builtin/repo.c > @@ -20,11 +20,17 @@ > #include "tree-walk.h" > #include "utf8.h" > > +#define REPO_INFO_USAGE \ > + "git repo info [--format=(lines|nul) | -z] [--all | ...]", \ > + "git repo info --keys [--format=(lines|nul) | -z]" > + > +#define REPO_STRUCTURE_USAGE \ > + "git repo structure [--format=(table|lines|nul) | -z]" > + > static const char *const repo_usage[] = { > - "git repo info [--format=(lines|nul) | -z] [--all | ...]", > - "git repo info --keys [--format=(lines|nul) | -z]", > - "git repo structure [--format=(table|lines|nul) | -z]", > - NULL > + REPO_INFO_USAGE, > + REPO_STRUCTURE_USAGE, > + NULL, > }; > > typedef int get_value_fn(struct repository *repo, struct strbuf *buf);