From: Junio C Hamano Date: Sat, 24 Oct 2026 02:06:23 GMT Subject: Re: [PATCH v2] negotiator/skipping.c: parse parents before queueing Message-ID: In-Reply-To: Taylor Blau writes: > But looking at it more closely, I think you're right that there is a bug > here in the default negotiator. So... > >> Would a hybrid approach to (1) avoid copying a mistake to new code and >> (2) document near the new code and/or in the log message that the >> difference is deliberate and fixing existing ones are #leftoverbits >> and not addressed in this commit? > > I think a hybrid approach is fine, though I am happy to fix the default > negotiator alongside this series. I have a patch for it locally, but I'm > happy to send either depending on your preference. If you have a clear grasp of the existing bug and the fix is straightforward, let's do the fix as part of this series. Thanks.