From: Junio C Hamano Date: Thu, 12 Nov 2026 17:53:47 GMT Subject: Re: [PATCH v3 00/15] Fix segfaults on settings given without a value Message-ID: In-Reply-To: Derrick Stolee writes: > On 11/11/2026 5:49 PM, Thomas Bachem via GitGitGadget wrote: >> A setting given without a value, as in "git -c foo.bar" or a bare "bar" >> under "[foo]", is passed as NULL to the code that reads it. In these places >> git does not check for that and segfaults: > > ... >> Changes since v2: >> >> * Where an invalid value is ignored, a missing one now is too, with a >> warning: remote.*.tagOpt (patch 6) and color.blame.repeatedLines (patch >> 7). v2 rejected them (Phillip). >> >> * The test in patch 1 rebases onto HEAD~3 and checks the result with >> test_commit_message (Phillip). > > I reviewed the range-diff and found it reasonable. > > But I was also happy with v2, so I look forward to > Phillip chiming in on v3. Thanks for writing and reviewing. Let me mark the topic as ready for 'next' then.