From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 18 Dec 2014 17:02:31 GMT
Subject: Re: [PATCHv3 4/6] receive-pack.c: use a single ref_transaction for atomic pushes
Message-ID: <xmqqppbg7uxk.fsf@gitster.dls.corp.google.com>
In-Reply-To: <CAGZ79kZCTb5Uj34Kj-qnQEWmD+4=3U8LyeHxQWmLg-ozJr7Azg@mail.gmail.com>

Stefan Beller <sbeller@google.com> writes:

> This would change the current behavior. In the case of !atomic we want
> to consider all commands and not stop early.

Quite right.

> So maybe more
> if (!cmd->error_string) {
>         if (!use_atomic
>             && ref_transaction_commit(...)) {
>             ...
>         }
> } else {
>         if (use_atomic)
>              goto check_atomic_commit;
> }

Don't you need to rollback/abort/free in one-at-a-time mode and did
not commit because error_string is already set, though?