From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 16 Sep 2015 22:54:50 GMT
Subject: Re: [PATCH 66/67] use strbuf_complete to conditionally append slash
Message-ID: <xmqqpp1ikm9x.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20150916223901.GA24945@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

>> Is this conversion correct?  This seems to me that the caller wants
>> to create an IMAP folder name immediately under the root hierarchy
>> and wants to have the leading slash in the result.
>
> Ugh, you're right. This is the "other" style Eric mentioned earlier.
>
> This looks like the only one in the patch (there are many that did not
> check buf.len at all, but if we assume they were not invoking undefined
> behavior before, then they are fine under the new code).

Yes, I should have said that earlier to save one roundtrip.

Thanks for working on this.