From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 21 Mar 2016 17:53:42 GMT
Subject: Re: [PATCH v2 0/2] git-p4: fix AsciiDoc formatting
Message-ID: <xmqqpounn2e1.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1458499161-61642-1-git-send-email-larsxschneider@gmail.com>

larsxschneider@gmail.com writes:

> From: Lars Schneider <larsxschneider@gmail.com>
>
> diff to v1:
> * reference external pages similar to git-bisect-lk2009 (thanks Luke)
> * fix quotation marks (you can see the error here:
>   https://git-scm.com/docs/git-p4/2.7.4 ... search for cp1252 )
>
> Thanks,
> Lars
>
>
> Lars Schneider (2):
>   Documentation: fix git-p4 AsciiDoc formatting
>   Documentation: use ASCII quotation marks in git-p4
>
>  Documentation/git-p4.txt | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)

Hmph, this seems to break my build.

xmlto: /home/gitster/w/git.git/Documentation/git-p4.xml does not validate (status 3)
xmlto: Fix document syntax or use --skip-validation option
/home/gitster/w/git.git/Documentation/git-p4.xml:812: element xref: validity error : Syntax of value for attribute linkend of xref is not valid
/home/gitster/w/git.git/Documentation/git-p4.xml:1077: element anchor: validity error : Syntax of value for attribute id of anchor is not valid
Document /home/gitster/w/git.git/Documentation/git-p4.xml does not validate


On line #812 of the generated file I see this:

        Only Git LFS <xref linkend="1"/> is implemented right now. Download

And line #1077 I see this:

<anchor id="1" xreflabel="[1]"/>[1] <ulink url="https://git-lfs.github.com/">Git LFS - An open source Git extension for versioning large files</ulink>

It could be that mimicking git-bisect-lk2009 that never is formatted
as manpage is a bad idea to begin with?

$ xmlto --version
xmlto version 0.0.25