From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 03 Nov 2017 13:44:08 GMT
Subject: Re: [PATCH 1/2] sequencer: factor out rewrite_file()
Message-ID: <xmqqpo8zpjdj.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20171103103248.4p45r4klojk5cf2g@ruderich.org>

Simon Ruderich <simon@ruderich.org> writes:

> I tried looking into this by adding a new write_file_buf_gently()
> (or maybe renaming write_file_buf to write_file_buf_or_die) and
> using it from write_file_buf() but I don't know the proper way to
> handle the error-case in write_file_buf(). Just calling
> die("write_file_buf") feels ugly, as the real error was already
> printed on screen by error_errno() and I didn't find any function
> to just exit without writing a message (which still respects
> die_routine). Suggestions welcome.

How about *not* printing the error at the place where you notice the
error, and instead return an error code to the caller to be noticed
which dies with an error message?