From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 07 Nov 2017 03:03:36 GMT
Subject: Re: [PATCH v1 3/8] commit: move post-rewrite code to libgit
Message-ID: <xmqqpo8ug587.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20171106112709.2121-4-phillip.wood@talktalk.net>

Phillip Wood <phillip.wood@talktalk.net> writes:

> From: Phillip Wood <phillip.wood@dunelm.org.uk>
>
> Move run_rewrite_hook() from bulitin/commit.c to sequencer.c so it can
> be shared with other commands and add a new function
> commit_post_rewrite() based on the code in builtin/commit.c that
> encapsulates rewriting notes and running the post-rewrite hook.

This, especially the part that rips out the notes rewriting from
builtin/commit.c and moves it to elsewhere, is a bit curious
separation of labor.  I guess we'll see why in later steps in the
series.

The change itself looks like a regression-free no-op, which is good.