From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 07 Dec 2017 21:59:39 GMT
Subject: Re: [PATCH v2 5/7] diff: use skip-to-optional-val in parsing --relative
Message-ID: <xmqqpo7qb3n8.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20171207211102.GA12850@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> On Thu, Dec 07, 2017 at 09:30:32AM -0800, Junio C Hamano wrote:
>
>> Signed-off-by: Junio C Hamano <gitster@pobox.com>
>> ---
>
> It might be worth mentioning why this conversion is pulled out from the
> others (because its "default" case is "do not touch the pointer").

I am not sure what you mean by "pulled out from the others".  I did
not intend to keep these 3 additional patches permanently; rather, I
did them to help Christian's rerolling the series, and I do not think
this one should be separate from other ones that use the _default()
variant when that happens.