From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 24 Apr 2018 23:44:19 GMT
Subject: Re: [PATCH 21/41] http: eliminate hard-coded constants
Message-ID: <xmqqpo2o5fvw.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CAN0heSoCsFYqDmwTRCzh2FGDnOghBqVBTCOa7yEw0jtQ3LxDbA@mail.gmail.com>

Martin Ågren <martin.agren@gmail.com> writes:

>>                 switch (data[i]) {
>>                 case 'P':
>>                         i++;
>> -                       if (i + 52 <= buf.len &&
>> +                       if (i + hexsz + 12 <= buf.len &&
>>                             starts_with(data + i, " pack-") &&
>> -                           starts_with(data + i + 46, ".pack\n")) {
>> -                               get_sha1_hex(data + i + 6, sha1);
>> -                               fetch_and_setup_pack_index(packs_head, sha1,
>> +                           starts_with(data + i + hexsz + 6, ".pack\n")) {
>> +                               get_sha1_hex(data + i + 6, hash);
>> +                               fetch_and_setup_pack_index(packs_head, hash,
>>                                                       base_url);
>>                                 i += 51;
>
> s/51/hexsz + 11/ ?

Quite right.