From: Junio C Hamano Date: Mon, 17 Jun 2019 19:54:43 GMT Subject: Re: js/gcc-8-and-9, was Re: What's cooking in git.git (Jun 2019, #04; Fri, 14) Message-ID: In-Reply-To: Johannes Schindelin writes: > Hi Junio, > > On Fri, 14 Jun 2019, Junio C Hamano wrote: > >> * js/gcc-8-and-9 (2019-06-13) 4 commits >> - config: avoid calling `labs()` on too-large data type >> - winansi: simplify loading the GetCurrentConsoleFontEx() function >> - kwset: allow building with GCC 8 >> - poll (mingw): allow compiling with GCC 8 and DEVELOPER=1 >> >> Code clean-up for new compilers. >> >> The 'kwset' one may want to be discussed a bit longer. Perhaps >> merge the other three earlier to 'next' and then to 'master' >> separately? > > Or just take the kwset one with an adjusted commit message because it may > turn out that the kwset update will be blocked for a while because of > licensing issues? Sorry, but I do not understand why you'd want to "take" one that you suspect may be blocked for a while. I'd rather see us unblock the other ones that are unproblematic, without taking them hostage, which was what I meant.