From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 15 Aug 2019 16:36:07 GMT
Subject: Re: minor interactive rebase regression: HEAD points to wrong commit while rewording
Message-ID: <xmqqpnl64c94.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <026d6615-3420-eb31-8c93-a6245f3be503@gmail.com>

Phillip Wood <phillip.wood123@gmail.com> writes:

> On 14/08/2019 22:20, SZEDER Gábor wrote:
>
> I changed the sequencer to always commit the cherry-pick and then run
> 'git commit --amend' for rewords [1]. Running
>
> 	time env GIT_EDITOR=true GIT_SEQUENCE_EDITOR='sed -i
> s/pick/reword/' ../bin-wrappers/git rebase -i --root
>
> over 100 commits I cannot see any real difference in the timings
> between master and that branch. Any difference is within the variation
> of the times of multiple runs. The change also fixes a bug when
> rewording a re-arranged root commit.

I guess that settles the "efficiency" story; besides, showing a
wrong intermediate state to users and scripts efficiently is just as
bad as showing a wrong state less efficiently.