From: Junio C Hamano Date: Thu, 01 Oct 2020 15:42:56 GMT Subject: Re: [PATCH v2 2/3] credentials: make line reading Windows compatible Message-ID: In-Reply-To: <20201001135417.GA3145610@coredump.intra.peff.net> Jeff King writes: > Yeah, I agree that just teaching git-credential's stdin to handle CR > would be an OK stopping point. I don't have a strong opinion on > credential-store's on disk format. At least allowing CRLF there is > _plausibly_ useful, unlike credential-cache--daemon's pipe. And I doubt > that making the change would hurt anybody. I agree 100% with all of the above, including the part that says it is also OK to let credential-store read from its files with line ending converted to CRLF. Thanks.