From: Junio C Hamano Date: Thu, 18 Feb 2021 20:37:19 GMT Subject: Re: [PATCH 2/6] commit: add amend suboption to --fixup to create amend! commit Message-ID: In-Reply-To: Junio C Hamano writes: >> ...Thanks, for pointing this out. Also, in the above method for >> alnum I think we can initialize an array of alnum[] instead of >> alphas[]. Or otherwise I was thinking to instead check: >> if (!isalnum(*c) && *c == ':') > > Sure a loop is fine, or alnum[] is fine, or just alpha[] is OK, I > would think. Do you foresee you'd need --fixup=chomp124:? > I somehow doubt it. Having said that, we may regret if we did not include some punctuation to allow for a multi-word keyword. IOW, "alpha plus dash" might be a reasonable minimum. But what keyword --fixup=: can take is entirely under our control, so it is not all that unreasonable if we just forced our developers some discipline to pick a single-word keyword for any of their future enhancements. It's not like we are opening up extensibility to the end-users, who may complain that the way they can spell their new is too limited. So if we already have alpha[] and/or a helper function that does strspn(alpha) that we can reuse elsewhere, I do not think it is worth to try supporting punctuation. Thanks.