From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 18 Feb 2021 22:30:10 GMT
Subject: Re: [PATCH v2 08/10] fsck.c: undefine temporary STR macro after use
Message-ID: <xmqqpn0xc8lp.fsf@gitster.g>
In-Reply-To: <20210218105840.11989-9-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

> In f417eed8cde (fsck: provide a function to parse fsck message IDs,
> 2015-06-22) the "STR" macro was introduced, but that short macro name
> was not undefined after use as was done earlier in the same series for
> the MSG_ID macro in c99ba492f1c (fsck: introduce identifiers for fsck
> messages, 2015-06-22).
>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
>  fsck.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/fsck.c b/fsck.c
> index 7c53080ad48..88884e91c89 100644
> --- a/fsck.c
> +++ b/fsck.c
> @@ -100,6 +100,7 @@ static struct {
>  	{ NULL, NULL, NULL, -1 }
>  };
>  #undef MSG_ID
> +#undef STR

Good clean-up.

>  
>  static void prepare_msg_ids(void)
>  {