From: Junio C Hamano Date: Thu, 16 Sep 2021 05:27:58 GMT Subject: Re: [PATCH 1/2] tree-diff: fix leak when not HAVE_ALLOCA Message-ID: In-Reply-To: <20210916023706.55760-2-carenas@gmail.com> Carlo Marcelo Arenas Belón writes: > b8ba412bf7 (tree-diff: avoid alloca for large allocations, 2016-06-07) > adds a way to route some bigger allocations out of the stack and free > them through the addition of two conveniently named macros, but leaves > the calls to free the xalloca part, which could be also in the heap, > if the system doesn't HAVE_ALLOCA (ex: macOS). Nicely spotted and analyzed. Thanks.