From: Junio C Hamano Date: Wed, 20 Oct 2021 14:39:02 GMT Subject: Re: [RFC PATCH v2 2/4] ref-filter API user: add and use a ref_sorting_release() Message-ID: In-Reply-To: Ævar Arnfjörð Bjarmason writes: > +void ref_sorting_release(struct ref_sorting *sorting) > +{ > + struct ref_sorting *next = sorting->next; > + if (next) > + ref_sorting_release(next); > + free(sorting); > +} Looks like a deep recursion that can be turned into an iteration fairly easily? I guess it does not matter as long as we won't deal with thousands of sort keys...