From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 18 Nov 2021 23:42:16 GMT
Subject: Re: [PATCH v2 2/2] test-lib: introduce required prereq for test runs
Message-ID: <xmqqpmqxuj3b.fsf@gitster.g>
In-Reply-To: <20211117090410.8013-3-fs@gigacodes.de>

Fabian Stelzer <fs@gigacodes.de> writes:

> +			# Abort if this prereq was marked as required
> +			if test -n $GIT_TEST_REQUIRE_PREREQ

If GIT_TEST_REQUIRE_PREREQ is an empty string, this will ask

	test -n

and "test" will say "yes" (because "-n" is not an empty string).

Let's surround it with a pair of double-quotes.

> +			then
> +				case ",$GIT_TEST_REQUIRE_PREREQ," in
> +				*,$prerequisite,*)
> +					error "required prereq $prerequisite failed"
> +					;;
> +				esac
> +			fi
> +
>  			if test -z "$missing_prereq"
>  			then
>  				missing_prereq=$prerequisite