From: Junio C Hamano Date: Mon, 27 Mar 2023 16:09:43 GMT Subject: Re: [PATCH v2] archive: improve support for running in subdirectory Message-ID: In-Reply-To: <7c33b01b-7b2a-25fa-9a66-1e65cd12bc84@web.de> René Scharfe writes: > + /* rel can refer to path, so don't edit it in place */ > + strbuf_reset(&new_path); > + strbuf_add(&new_path, args->base, args->baselen); > + strbuf_addstr(&new_path, rel); > + strbuf_swap(&path, &new_path); Thanks. That indeed was nasty and tricky.