From: Junio C Hamano Date: Mon, 12 Jun 2023 21:19:01 GMT Subject: Re: [PATCH] pack-bitmap.c: gracefully degrade on failure to load MIDX'd pack Message-ID: In-Reply-To: Taylor Blau writes: > When opening a MIDX bitmap, we the pack-bitmap machinery eagerly calls I guess s/we // is needed here? > When opening one of these packs fails, the pack-bitmap code will `die()` > indicating that it can't open one of the packs in the MIDX. This > indicates that the MIDX is somehow broken with respect to the current > state of the repository. When this is the case, we indeed cannot make > use of the MIDX bitmap to speed up reachability traversals. > > However, it does not mean that we can't perform reachability traversals > at all. In other failure modes, that same function calls `warning()` and > then returns -1, indicating to its caller (`open_bitmap()`) that we > should either look for a pack bitmap if one is available, or perform > normal object traversal without using bitmaps at all. Makes sense.