From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 10 Oct 2023 20:57:25 GMT
Subject: Re: [PATCH v4 4/4] parse: separate out parsing functions from config.h
Message-ID: <xmqqpm1mrya2.fsf@gitster.g>
In-Reply-To: <87c16c09-784f-4818-9231-8023fc2c5a02@gmail.com>

Phillip Wood <phillip.wood123@gmail.com> writes:

>> I'm open to changing
>> git_config_get_expiry_date_in_days() too, though...we probably don't
>> need so many days.
>
> Indeed, the existing code passes maximum_signed_value_of_type(int) as
> the third argument to limit it to INT_MAX already.

Yeah, in other words, the current implementation does not allow us
to express the days more than an int can, so it is no brainer to
switch to use git_parse_int().  Allowing longer expiration period
is obviously outside the scope of this series.

Thanks.