From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 21 Aug 2024 16:08:30 GMT
Subject: Re: [GSoC][PATCH v4] t: migrate t0110-urlmatch-normalization to the new framework
Message-ID: <xmqqplq1270h.fsf@gitster.g>
In-Reply-To: <CAP8UFD1WJqKUe-SA=w0oGQNgpLdaQNkc5Uh0rZtmCvDD1oQk7A@mail.gmail.com>

Christian Couder <christian.couder@gmail.com> writes:

> On Tue, Aug 20, 2024 at 5:20 PM Ghanshyam Thakkar
> <shyamthakkar001@gmail.com> wrote:
>>
>> helper/test-urlmatch-normalization along with
>> t0110-urlmatch-normalization test the `url_normalize()` function from
>> 'urlmatch.h'. Migrate them to the unit testing framework for better
>> performance. And also add different test_msg()s for better debugging.
>
> This version addresses all the suggestions (nits actually) to improve
> the previous version, so it seems to me that it is good to go.

Looking good to me, too.  Thanks, both.

Will queue.  Let me mark it for 'next' in my "What's cooking" draft.