From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 06 Jun 2025 01:28:31 GMT
Subject: Re: [PATCH v6] pack-bitmap: remove checks before bitmap_free
Message-ID: <xmqqplfh64lc.fsf@gitster.g>
In-Reply-To: <pull.1977.v6.git.git.1749138820241.gitgitgadget@gmail.com>

"Lidong Yan via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Lidong Yan <502024330056@smail.nju.edu.cn>
>
> In pack-bitmap.c:find_boundary_objects(), the roots_bitmap is only freed
> if cascade_pseudo_merges_1() fails. Since cascade_pseudo_merges_1() only
> use roots_bitmap as a mutable reference but not takes roots_bitmap's
> ownership.

Sorry but I cannot parse the last sentence above.  I would have
expected that "Since/Because X" to be followed by comma and a
sentence that describes the consequence of X.  Also "but not takes"
-> "but does not take", probably.