From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 30 Jul 2025 20:07:10 GMT
Subject: Re: [PATCH 1/5] git-gui: remove uname_O in Makefile
Message-ID: <xmqqpldhl9xt.fsf@gitster.g>
In-Reply-To: <20250730164052.15371-2-carenas@gmail.com>

Carlo Marcelo Arenas Belón <carenas@gmail.com> writes:

> Last used in ae49066 (git gui Makefile - remove Cygwin modifications,
> 2023-06-26), and unused since.
>
> Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
> ---
>  Makefile | 1 -
>  1 file changed, 1 deletion(-)

An obvious improvement ;-).

> diff --git a/Makefile b/Makefile
> index 315888f..a87dc06 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -11,7 +11,6 @@ GIT-VERSION-FILE: FORCE
>  	@$(SHELL_PATH) ./GIT-VERSION-GEN . $@
>  
>  uname_S := $(shell sh -c 'uname -s 2>/dev/null || echo not')
> -uname_O := $(shell sh -c 'uname -o 2>/dev/null || echo not')
>  uname_R := $(shell sh -c 'uname -r 2>/dev/null || echo not')
>  
>  SCRIPT_SH = git-gui.sh