From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 31 Jul 2025 23:57:20 GMT
Subject: Re: [PATCH v6 0/4] Introduce git-last-modified(1) command
Message-ID: <xmqqpldfoqvz.fsf@gitster.g>
In-Reply-To: <xmqq1ppwryoy.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

> Toon Claes <toon@iotcl.com> writes:
>
>> Changes in v6:
>> - Only the first 3 patches are kept. The last 3 patches worked toward adding an
>>   extra option `--format`. The way it was implemented was heavily debatable and
>>   in the end it is not required for a first iteration, so they are dropped.
>
> OK.
>
>> - Function prepare_commit_graph() is exported and used in
>>   generation_numbers_enabled().
>
> OK.
>
>> - Since the library layer was removed and all the code was moved into the
>>   builtin, there was still some leftovers from using a callback mechanism to
>>   display the results. This is removed (as far as possible) and instead
>>   last_modified_emit() always, this function was called show_entry() previously.
>
> OK.
>
>> - Code is rebased to use refactoring in the bloom filter API.
>
> Ah, bloom_key_fill() and bloom_key_clear(); sorry to see you become
> a victim of an unfortunate churn X-<, but hopefully it is for
> greater good in the longer term.
>
> Will queue.  Thanks.

CI runs without and with this topic in 'seen'

(without this topic)
https://github.com/git/git/actions/runs/16661801008

(with this topic)
https://github.com/git/git/actions/runs/16662408099

The difference in trees of these two runs match what is in this
topic and nothing else.