From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 22 Mar 2026 21:55:47 GMT
Subject: Re: [PATCH] t/t2107-update-index-basic: use test_path_is_missing
Message-ID: <xmqqpl4v7cm4.fsf@gitster.g>
In-Reply-To: <pull.2250.git.git.1774197600379.gitgitgadget@gmail.com>

"Jayesh Daga via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: jayesh0104 <jayeshdaga99@gmail.com>

The author identifier (name and email) used here to identify the
author must match the identifier used to sign-off.  You'd probably
need to "git commit --amend --reset-author" this commit with updatec
user.name set to "Jayesh Daga", not "jayesh0104" or something.

>
> Replace a raw '! test -f' check with test_path_is_missing to
> use the standard test helper and improve consistency with
> other tests.
>
> Signed-off-by: Jayesh Daga <jayeshdaga99@gmail.com>
> ---
>  t/t2107-update-index-basic.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t2107-update-index-basic.sh b/t/t2107-update-index-basic.sh
> index cc72ead79f..3bffe5da8a 100755
> --- a/t/t2107-update-index-basic.sh
> +++ b/t/t2107-update-index-basic.sh
> @@ -86,7 +86,7 @@ test_expect_success '.lock files cleaned up' '
>  	# the_index.cache_changed is zero, rollback_lock_file fails
>  	git update-index --refresh --verbose >out &&
>  	test_must_be_empty out &&
> -	! test -f .git/index.lock
> +	test_path_is_missing .git/index.lock
>  	)
>  '
>  
>
> base-commit: 6e8d538aab8fe4dd07ba9fb87b5c7edcfa5706ad