From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 30 Mar 2026 20:04:21 GMT
Subject: Re: [PATCH v4] read-cache: use istate->repo for trace2 logging
Message-ID: <xmqqpl4ldqyi.fsf@gitster.g>
In-Reply-To: <pull.2253.v4.git.git.1774895886678.gitgitgadget@gmail.com>

"Jayesh Daga via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Jayesh Daga <jayeshdaga99@gmail.com>
>
> trace2 calls in read-cache.c use the global 'the_repository',
> even though the relevant index_state provides an explicit
> repository pointer via 'istate->repo'.
>
> Using the global repository can result in incorrect trace2
> output when multiple repository instances are in use, as
> events may be attributed to the wrong repository.
>
> Use 'istate->repo' instead to ensure correct repository
> attribution.
>
> Signed-off-by: Jayesh Daga <jayeshdaga99@gmail.com>
> ---
> Range-diff vs v3:
>
>  1:  5a8165b05d < -:  ---------- repo: add paths.git_dir repo info key
>  2:  9bb6d0fa01 = 1:  c99d731efa read-cache: use istate->repo for trace2 logging

A range-diff with v2 would have been much more relevant, but the
patch below looks super boring compared to v2 which is very good.
Just replacing the_repository with istate->repo and nothing else,
which is exactly we expect to see from the patch title above ;-)

Will queue.  Thanks.