From: Junio C Hamano Date: Tue, 31 Mar 2026 21:23:55 GMT Subject: Re: [PATCH 1/6] reftable/system: provide `REFTABLE_INLINE()` macro Message-ID: In-Reply-To: <054e69e8-3dab-4321-b68c-a48d43dc052f@web.de> René Scharfe writes: > On 3/31/26 1:26 PM, Patrick Steinhardt wrote: >> Not every compiler knows about the `inline` annotation for functions. >> Consequently, Git knows to define `inline` as an empty macro in case >> it's not available. > > Does it? Only in compat/regex/regex_internal.h, which does not leak > to other code, no? As we also do ifneq (,$(INLINE)) BASIC_CFLAGS += -Dinline=$(INLINE) endif in the Makefile so we cannot tell what people do with their config.mak ;-). And obviously other projects do not share our Makefile, so it is not too much of stretch to say Git "knows to define", even though it may be more precise to say "knows to let users redefine", perhaps?