From: Junio C Hamano Date: Tue, 16 Jun 2026 17:33:30 GMT Subject: Re: [PATCH] rebase: mention --abort alongside --continue Message-ID: In-Reply-To: <89d72342-5aa1-4dcf-951b-d0c791f91738@gmail.com> Phillip Wood writes: > Hi Harald > > On 15/06/2026 20:19, Harald Nordgren via GitGitGadget wrote: >> From: Harald Nordgren >> >> The warning shown when an "exec" step fails and the "git status" >> advice while splitting or editing a commit pointed users at "git >> rebase --continue" but not "--abort". Mention it in both, matching >> the conflict case. > > I'm not sure that the "failed exec" and "conflicts" cases are equivalent > though. If you have some nasty conflict that you don't want to resolve > then aborting and trying another approach such is incrementally rebasing > is the only option. If an exec command fails then it likely means that a > test has failed or some something similar which is minor inconvenience > which needs fixing before continuing - it seems very unlikely that the > user would want to abort the rebase. It is very true that users who know what they are doing and got into such conflicts are opted to go into such a situation tnat it is unlikely that they would appreciate a choice to abort. But given that for any system, everybody starts as a newbie, it may be assuring to always give "here is a way out" option when they get in a nasty confusing situation. Discouraging the way to use the tool that can lead to confusing situation by guiding them with BCP workflows would help, but they always get into pitfall. The patch adds new message into the existing message to suggest how to move forward, but as a training wheel option, it may not be a bad thing to offer "--abort" as an extra hint, separate from the existing warning() message.