From: Junio C Hamano Date: Sat, 20 Jun 2026 15:18:01 GMT Subject: Re: [PATCH] environment: use 'repo->initialized' for repo_protect_hfs() and repo_protect_ntfs() Message-ID: In-Reply-To: <20260620140957.667820-1-cat@malon.dev> Tian Yuchen writes: > To match how we refrain from calling repo_config_values() on an > uninitialized instance of a repository object in other two topics > that deal with ignore_case and trust_executable_bit, check the > repo->initialized bit instead of the repo->gitdir member. OK. > Base commit: 43192e7977f5f05138abcdb3212a3f87ab513bef This line does not belong here. Besides, you do not build directly on top of 'next', ever. > Mentored-by: Christian Couder > Mentored-by: Ayush Chandekar > Mentored-by: Olamide Caleb Bello > Signed-off-by: Tian Yuchen > --- > environment.c | 4 ++-- > environment.h | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) I'll queue the change directly on top of ty/move-protect-hfs-ntfs topic, which will be merged to 'next'. Thanks. > diff --git a/environment.c b/environment.c > index 6ee11e9fc8..8f0c1c4f25 100644 > --- a/environment.c > +++ b/environment.c > @@ -130,14 +130,14 @@ int is_bare_repository(struct repository *repo) > > int repo_protect_ntfs(struct repository *repo) > { > - return repo->gitdir ? > + return (repo && repo->initialized) ? > repo_config_values(repo)->protect_ntfs : > PROTECT_NTFS_DEFAULT; > } > > int repo_protect_hfs(struct repository *repo) > { > - return repo->gitdir ? > + return (repo && repo->initialized) ? > repo_config_values(repo)->protect_hfs : > PROTECT_HFS_DEFAULT; > } > diff --git a/environment.h b/environment.h > index d188955f5b..8aaedcfea3 100644 > --- a/environment.h > +++ b/environment.h > @@ -137,8 +137,8 @@ int git_default_core_config(const char *var, const char *value, > > /* > * Getters for the `protect_hfs` and `protect_ntfs` fields of `struct repo_config_values`. > - * They check `repo->gitdir` to prevent calling repo_config_values() > - * before the configuration is loaded or in bare environments. > + * They check `repo->initialized` to prevent calling `repo_config_values()` > + * before the repository setup is fully complete or in non-git environments. > */ > int repo_protect_hfs(struct repository *repo); > int repo_protect_ntfs(struct repository *repo);