From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 24 Jun 2026 20:19:47 GMT
Subject: Re: [PATCH GSoC RFC v13 06/12] connect: refactor packet writing
Message-ID: <xmqqpl1fhesc.fsf@gitster.g>
In-Reply-To: <CAOLa=ZSvxXuf_bSzKMvViNQ5MuDAqxnQdo4asF9vfMhJaDQcVw@mail.gmail.com>

Karthik Nayak <karthik.188@gmail.com> writes:

>> +/*
>> + * Writes a command along with the requested server capabilities/features into a
>> + * request buffer.
>> + */
>>  struct string_list;
>
> The comment should be above the function and not the forward
> declaration.
>
> While we're here, why not `#include "string-list.h"` and remove the
> forward declaration, is there a circular dependency?

Isn't it to avoid unnecessary include?  When the header itself only
needs to know about the presence of the type, and not the concrete
shape of the type (e.g., because it only uses a pointer to that
type), it may be overkill to include the entire header file.