From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 05 Jul 2026 04:08:02 GMT
Subject: Re: [PATCH v4 0/2] Makefile: link osxkeychain helper against Rust
Message-ID: <xmqqpl12dqot.fsf@gitster.g>
In-Reply-To: <pull.2288.v4.git.git.1783188355.gitgitgadget@gmail.com>

"Shardul Natu via GitGitGadget" <gitgitgadget@gmail.com> writes:

> Changes since v2:
>
>  * Split the original combined commit into a two-patch series to separate
>    prerequisite bug fixes from Universal Binary features.

This was addressing Patrick's comment, which was already done in v3;
hopefully that is now settled?

>  * Added $(call mkdir_p_parent_template) prior to invoking lipo to guarantee
>    that parent target directories exist.

Obviously correct ;-).

>  * 
>

It is a mystery what the third bullet point was ;-)

The changes relative to v3 (which I looked at) look good now.

Thanks.