From: Junio C Hamano Date: Mon, 26 Oct 2026 20:32:45 GMT Subject: Re: [PATCH v7 1/1] archive-zip: refactor 'path too long' error message to use Q_() Message-ID: In-Reply-To: <20261026190423.1925-2-kerylefondji7@gmail.com> kerylefondji7@gmail.com writes: A few things. * Please do not send the same [v7] multiple times. * Please do not send your [v7] cover letter as a respopnse to a random other message; instead make it in resonse to previous rounds (either [v6] or [v1]). These harm automation. Also * Patches [1/n]..[n/n] should be sent as a response to cover letter [0/n]. This [v7 1/1] correctly responds to [v7 0/1], but if gotten wrong, it would harm automation, too. It also is more usual to send a single patch without cover letter. > From: Keryle Fondji > > Replace _() with Q_() in the 'path too long' error message. Although > pathlen is always greater than 0xffff when this error is hit, Q_() is > required to support correct translation for languages that require > different plural forms depending on the count. Nicely described. > Signed-off-by: Keryle Fondji > --- > archive-zip.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > diff --git a/archive-zip.c b/archive-zip.c > index 6f73ca6d58..160efd878f 100644 > --- a/archive-zip.c > +++ b/archive-zip.c > @@ -328,8 +328,10 @@ static int write_zip_entry(struct archiver_args *args, > } > > if (pathlen > 0xffff) { > - return error(_("path too long (%d chars, SHA1: %s): %s"), > - (int)pathlen, oid_to_hex(oid), path); > + return error(Q_("path too long (%d char, SHA1: %s): %s", > + "path too long (%d chars, SHA1: %s): %s", > + pathlen), > + (int)pathlen, oid_to_hex(oid), path); > } This is outside the scope of this patch, but we may want to update "SHA1" with something like "object name", so that the error message works even in SHA-256 repository.