From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 19 Sep 2013 17:13:51 GMT
Subject: Re: [PATCH v4] Teach git to change to a given directory using -C option
Message-ID: <xmqqob7ou434.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20130919131854.GA19790@gmail.com>

Nazri Ramliy <ayiehere@gmail.com> writes:

> Now I'm noticing that you've already made the above fixes in next ;)

Yes.  I said I'd locally tweak and queue, didn't I?

>>> +test_expect_success '"git -C <path>" runs git from the directory <path>' '
>>> +     test_create_repo dir1 &&
>>> +     echo 1 >dir1/a.txt &&
>>> +     (cd dir1 && git add a.txt && git commit -m "initial in dir1") &&
>>
>> Curious why this does not use -C here.
>
> It didn't use -C there because it's in the "prepare the expected test
> output" stage and we want that to succeed, whether -C works or not - we
> haven't reached the part where we are actually testing the -C option,

Good thinking.

Will queue as an incremental update on top of what is already in 'next'.

Thanks.