From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 01 Jun 2016 16:13:09 GMT
Subject: Re: [BUG] git-submodule has bash-ism?
Message-ID: <xmqqoa7kzy3u.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <xmqq1t4h3jxo.fsf@gitster.mtv.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

> relative_path ()
> {
> 	local target curdir result
> 	target=$1
> 	curdir=${2-$wt_prefix}
>
> I am hoping that Stefan's "gradually rewrite things in C" will make
> it unnecessary to worry about this one.  "git submodule" would not
> work correctly on posixly correct shells in the meantime.

These are two other offenders.

$ git grep '^[	 ]local[ 	]' \*.sh
t/t5500-fetch-pack.sh:	local diagport
t/t7403-submodule-sync.sh:	local root

The grep gives many other hits, but those in completion are OK; it
is designed to be specific to bash, and whose tests in t9902 is in
the same boat.  A few more near the end of t/test-lib-functions are
only for mingw where bash is the only supported shell at least for
running tests.