From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 24 Aug 2016 19:30:46 GMT
Subject: Re: [PATCH v3 0/3] limit the size of the packs we receive
Message-ID: <xmqqoa4iotg9.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160824184157.19264-1-chriscool@tuxfamily.org>

Christian Couder <christian.couder@gmail.com> writes:

> Diff with previous v2 version
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> diff --git a/Documentation/config.txt b/Documentation/config.txt
> index f5b6061..8a115b3 100644
> --- a/Documentation/config.txt
> +++ b/Documentation/config.txt
> @@ -2517,10 +2517,11 @@ receive.unpackLimit::
>  	especially on slow filesystems.  If not set, the value of
>  	`transfer.unpackLimit` is used instead.
>  
> -receive.maxsize::
> -	If the size of a pack file is larger than this limit, then
> -	git-receive-pack will error out, instead of accepting the pack
> -	file. If not set or set to 0, then the size is unlimited.
> +receive.maxInputSize::
> +	If the size of the incoming pack stream is larger than this
> +	limit, then git-receive-pack will error out, instead of
> +	accepting the pack file. If not set or set to 0, then the size
> +	is unlimited.
>  
>  receive.denyDeletes::
>  	If set to true, git-receive-pack will deny a ref update that deletes
> diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c
> ...
> diff --git a/t/t5546-receive-limits.sh b/t/t5546-receive-limits.sh
> new file mode 100755
> index 0000000..10cb0be
> --- /dev/null
> +++ b/t/t5546-receive-limits.sh
> @@ -0,0 +1,55 @@
> +#!/bin/sh
> + ...
> +test_done
> ---
>
> Christian Couder (1):
>   unpack-objects: add --max-input-size=<size> option
>
> Jeff King (2):
>   index-pack: add --max-input-size=<size> option
>   receive-pack: allow a maximum input size to be specified

This was a pleasant read.  All looked sensible.

Thanks.