From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 28 Sep 2016 20:21:13 GMT
Subject: Re: [PATCH v4 1/2] t5100-mailinfo: replace common path prefix with variable
Message-ID: <xmqqoa37ixmu.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160928195232.7843-1-me@ikke.info>

Kevin Daudt <me@ikke.info> writes:

> Many tests need to store data in a file, and repeat the same pattern to
> refer to that path:
>
>     "$TEST_DIRECTORY"/t5100/
>
> Create a variable that contains this path, and use that instead.
>
> While we're making this change, make sure the quotes are not just around
> the variable, but around the entire string to not give the impression
> we want shell splitting to affect the other variables.

Wow.  I was half expecting that you'd say something like "1/2 plus
the SQUASH is OK by me", but you went extra mile to do it right.

Impressed, and very much appreciated.