From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 13 Dec 2016 20:10:22 GMT
Subject: Re: [PATCH 2/2] tmp-objdir: quote paths we add to alternates
Message-ID: <xmqqoa0f1tg1.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20161213181538.6gv4it4b33uhbuud@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> On Tue, Dec 13, 2016 at 10:10:04AM -0800, Junio C Hamano wrote:
>
>> > -	git clone --bare . xxx:yyy.git &&
>> > +	git clone --bare . xxx${path_sep}yyy.git &&
>> 
>> Don't you want to dq the whole thing to prevent the shell from
>> splitting this into two commands at ';'?  The other one below is OK.
>
> After expansion, I don't think the shell will do any further processing
> except for whitespace splitting. E.g.:

Ah, my mistake.  Staring at too many `eval`s does it to me.

Thanks.