From: Junio C Hamano Date: Fri, 06 Jul 2018 19:58:14 GMT Subject: Re: [PATCH 3/8] gpg-interface: add new config to select how to sign a commit Message-ID: In-Reply-To: <20180706010148.GA7697@genre.crustytoothpaste.net> "brian m. carlson" writes: > On Tue, Jul 03, 2018 at 02:38:15PM +0200, Henning Schild wrote: >> Add "gpg.format" where the user can specify which type of signature to >> use for commits. At the moment only "PGP" is supported and the value is >> not even used. This commit prepares for a new types of signatures. > > We typically prefer to have option values specified in lower case. I > also think "openpgp" might be better than "PGP", since that's the name > of the specification and it would avoid any potential unhappiness about > compatibility with PGP or trademarks. I do not know about trademarks, but the suggested "'openpgp' in lowercase" sounds sensible. Some people might even favor doing strcasecmp() on the value; I do not have a strong opinion on that yet.