From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 12 Jan 2019 03:08:10 GMT
Subject: Re: [PATCH 4/6] init: make a copy of $GIT_DIR string
Message-ID: <xmqqo98mwp2d.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190111221631.GD10188@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> We pass the result of getenv("GIT_DIR") to init_db() and assume that the
> string remains valid. But that's not guaranteed across calls to setenv()
> or even getenv(), although it often works in practice. Let's make a copy
> of the string so that we follow the rules.
>
> Note that we need to mark it with UNLEAK(), since the value persists
> until the end of program (but we have no opportunity to free it).

Makes sense.  Thanks.